On Jul 17, 2012 2:06 PM, "Julian Foad" <julianf...@btopenworld.com> wrote: > > Can the Ev2 experts comment on these queries? > > > Index: subversion/include/svn_editor.h > =================================================================== > --- subversion/include/svn_editor.h (revision 1362611) > +++ subversion/include/svn_editor.h (working copy) > @@ -247,18 +247,26 @@ > * must be driven in adherence to these rules: > * > * - If any path is added (with add_*) or deleted/moved/rotated, then > + * ### JAF: Or copied?
Yes. The add_* is too narrow. > + * ### JAF: Rewrite as: "If any path is added or removed or replaced > + * (with add_*, delete, copy, move, rotate), then ..."? Yes. > * an svn_editor_alter_directory() call must be made for its parent > * directory with the target/eventual set of children. > + * ### JAF: Even if initial & eventual sets of children are identical? No. If they are identical, then you are replacing one or more nodes. > * > * - svn_editor_add_directory() -- Another svn_editor_add_*() call must > + * ### JAF: Or copy-here or move-here call? Or rotate, yes. > * follow for each child mentioned in the @a children argument of any > * svn_editor_add_directory() call. > + * ### JAF: Also for each new child of any alter_directory() call? Yes. > * > * - For each node created with add_*, if its parent was created using > + * ### JAF: node created with add_* or copy or move-here? No. Copy/move arrives with children already. > * svn_editor_add_directory(), then the new child node MUST have been > * mentioned in the @a children parameter of the parent's creation. > * This allows the parent directory to properly mark the child as > * "incomplete" until the child's add_* call arrives. > + * ### JAF: Also for each new child of any alter_directory() call? Yes. > * > * - A path should never be referenced more than once by the add_*, alter_*, > * and delete operations (the "Once Rule"). The source path of a copy (and > > > - Julian > > -- > Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
