On 11/05/2012 08:30 PM, Justin Erenkrantz wrote: > On Mon, Nov 5, 2012 at 1:33 PM, C. Michael Pilato <cmpil...@collab.net> wrote: >> My debugging indicates that when close_all_dirs() is called, there are a >> slew of unclosed directories which each have a non-zero ref_count. Save for >> the root directory of the edit (/tags), fetch_props == TRUE, >> propfind_handler->done == TRUE, and tag_closed == TRUE for all open child >> directories. So I'm looking around at how file references are managed to >> see if anything has leaked. I might have inadvertently botched something >> when adding the pull-contents-from-the-wc-cache logic. > > Yup - your analysis is pretty accurate IIRC. I posted about this when > I was in Berlin and even had a few patches to start to clean this up. > However, Greg was planning on redoing how we parse the XML report; > when that happens, some of this management should be far simpler (as > we know when the tags are closed) - so the thinking was to wait until > that was done and then assess whether that was fixed or not. -- > justin >
I recall this patch of yours -- I even asked you about it post-Berlin. I'll take a look at it now and see if it can help us out. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Enterprise Cloud Development
signature.asc
Description: OpenPGP digital signature
