On 09/04/2012 12:58 PM, Igor Galić wrote: > Hey folks, > > I've patched up my local mailer.py[1] to correctly encode > "From: " Headers. > > The attached patch *works* but it's not pretty. > > Someone who actually knows Python might want to encapsulate > my changes in a function. > > n.b.: I am not subscribed to this ML, if you want notify me > of updates, please CC me. > > So long, > > i > > [1] > http://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/mailer/mailer.py >
Igor, I took a look at your patch. I was confused by one aspect: why split the from_addr into words an encode each one individually, rather than encoding the whole header value like we do for the Subject: header? I dug around in the related RFCs, and if I'm reading the RFCs correctly, doing per-word encoding is actually the right thing to do. Should we, then, do the same for the Subject: header? -- C. Michael Pilato <[email protected]> CollabNet <> www.collab.net <> Enterprise Cloud Development
signature.asc
Description: OpenPGP digital signature
