On 11/12/12 00:46, Daniel Shahaf wrote:
Need parentheses around the symbol name. Lines should be wrapped at 80
characters and subsequent lines indented.
The web page instructions[1] need updating because they doesn't mention
this and so, I was trying to stay under a 72 character limit for the
mailing list.
The test needs an @XFail decorator, since it currently FAILs. And an
@Issue decorator, to associate it with #4263.
I hope to have corrected all outstanding issues in the attached files.
Re your other mail about OPW, you shouldn't let yourself be blocked by
this --- while this patch is outstanding, you should feel free to work
on another patch. The natural choice would be the C patch that turns
this test from XFAIL to PASS.
I will attempt to do just this. Also your tip with the libtool was much
appreciated, thank you very much :)
regards,
Gabriela
[1] http://subversion.apache.org/docs/community-guide/general.html#patches
Index: subversion/tests/cmdline/svnrdump_tests.py
===================================================================
--- subversion/tests/cmdline/svnrdump_tests.py (revision 1420388)
+++ subversion/tests/cmdline/svnrdump_tests.py (working copy)
@@ -356,6 +356,12 @@ def copy_bad_line_endings_dump(sbox):
expected_dumpfile_name="copy-bad-line-endings.expected.dump",
bypass_prop_validation=True)
+@XFail()
+@Issue(4263)
+def copy_bad_line_endings_load(sbox):
+ "load: inconsistent line endings in svn:* props"
+ run_load_test(sbox, "copy-bad-line-endings.dump")
+
def copy_bad_line_endings2_dump(sbox):
"dump: non-LF line endings in svn:* props"
run_dump_test(sbox, "copy-bad-line-endings2.dump",
@@ -771,6 +777,7 @@ test_list = [ None,
move_and_modify_in_the_same_revision_dump,
move_and_modify_in_the_same_revision_load,
copy_bad_line_endings_dump,
+ copy_bad_line_endings_load,
copy_bad_line_endings2_dump,
commit_a_copy_of_root_dump,
commit_a_copy_of_root_load,
[[[
Test for issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in
'svn:log' property
* subversion/tests/cmdline/svnrdump_tests.py
(copy_bad_line_endings_load): Test for '\r' line ending bug in svnrdump
(issue 4263)
]]]
