On Tue, Dec 11, 2012 at 4:50 PM, Gabriela Gibson <gabriela.gib...@gmail.com> wrote: > I'm concerned that I shouldn't be altering fs-wrap.c. So a logical > place to put a fix is probably in (set_revision_property). > > I could either hand code a "for" loop, or call the function > (svn_rdump__normalize_props) in svnrdump/util.c > > So, to summarise, my options seem to be: > > 1. Alter (svn_repos__validate_prop) to replace '\r' with '<space>'. > 2. Hand code a loop at load_editor.c:857 > 3. Make a call to (svn_rdump__normalize_props) at load_editor.c:857 > 4. Make a call to to (svn_subst_translate_cstring2) at > load_editor.c:857 > > Which is the preferred option?
Option 5. Refactor the svn_rdump__normalize_props to use a function that you can also use from the load editor to normalize a single property. I think what was done to svnsync in r877869 should be instructive to you. I tracked that down by looking at the issue that's referenced in the issue you're looking at, which then says it is fixed in r37795. When we migrated from tigris.org to apache.org for our repo hosting our revision numbers changed. Fortunately our bot on IRC is helpful with this: 17:22 [msg(wayita)] #svn r37795 17:22 [wayita(~way...@svn-qavm.apache.org )] breser: r37795 <-> r877869