vijay <vi...@collab.net> writes: > The function svn_ra_serf__replay_range() doesn't return any error > while running 'svnrdump dump -rN:M <URL-deleted-in-HEAD>'[Issue #4100]. > It behaves as if the dump completed successfully. > > * subversion/libsvn_ra_serf/replay.c > (svn_ra_serf__replay_range): Handle the errors from server's response as > well as any errors found while running the serf loop.
Consider adding a regression test to svnrdump_tests.py. > /* Run the serf loop. */ > - SVN_ERR(svn_ra_serf__context_run_wait(&replay_ctx->done, session, > pool)); > + err = svn_ra_serf__context_run_wait(&replay_ctx->done, session, pool); > > + /* Handle the errors from server's response as well as any errors > + found while running the serf loop. */ > + SVN_ERR(svn_error_compose_create( > + svn_ra_serf__error_on_status(handler->sline.code, > + handler->path, > + handler->location), > + err)); > + When I see this sort of change I wonder if it needs to be applied anywhere else. The call in update.c:svn_ra_serf__get_file also uses SVN_ERR. Does it need the same fix? -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
