Hideki IWAMOTO wrote on Sat, Dec 29, 2012 at 21:30:32 +0900: > Hi. > > > Hi Hideki, thanks for the patch. I hope Johan or Julian will have > > a look (probably next year), but if you don't get a response please ping > > the thread and I'll have a look. > > I created issue #4283 for diff optimization bug and assigned to Johan. >
OK, thanks for this. Could you set a more descriptive 'summary' on the issue, please? i.e., describe the bug, not just state that there is one. (Also, Johan is just a volunteer and might not have time to look into the bug, despite the fact you've assigned it to him; I suppose you know that, but restating it won't hurt.) Cheers Daniel > On Sat, 29 Dec 2012 02:00:02 +0200 > Daniel Shahaf <danie...@elego.de> wrote: > > > Hi Hideki, thanks for the patch. I hope Johan or Julian will have > > a look (probably next year), but if you don't get a response please ping > > the thread and I'll have a look. > > > > Hideki IWAMOTO wrote on Sat, Dec 29, 2012 at 08:25:07 +0900: > > > Hi, Daniel. > > > > > > > Because I assumed using svn_diff_mem_* would reproduce issue #4133. If > > > > it doesn't, the test should be amended to use an API that will reproduce > > > > the issue. > > > > > > The cause of issue #4133 is a bugs in the calculations of > > > svn_diff__file_token_t::norm_offset. > > > > > > The test that you added is for different problem. (whitespaces at > > > the end of line are not ignored even if option `-x -b' option is > > > specified.) > > > > > > patch for issue #4133 is pattached. > > > > > > subversion/libsvn_diff/diff_file.c | 13 ++- > > > subversion/tests/libsvn_diff/diff-diff3-test.c | 89 > > > ++++++++++++++++++------- > > > 2 files changed, 75 insertions(+), 27 deletions(-) > > -- > Hideki IWAMOTO <h-iwam...@kit.hi-ho.ne.jp> >
