On Thu, Jan 03, 2013 at 06:09:33AM +0200, Daniel Shahaf wrote:
>
> Something's missing.
>
> If gtest is a dependency of svn 1.8, you should add it to the usage
> message of the script; if it's not, there's no reason to download it in
> the argc == 1 branch.
I have attached a patch, thank you for the comments.
Index: get-deps.sh
===================================================================
--- get-deps.sh (revision 1428602)
+++ get-deps.sh (working copy)
@@ -51,7 +51,7 @@ APACHE_MIRROR=http://archive.apache.org/dist
# helpers
usage() {
echo "Usage: $0"
- echo "Usage: $0 [ apr | serf | zlib | sqlite ] ..."
+ echo "Usage: $0 [ apr | serf | zlib | sqlite | gtest ] ..."
exit $1
}
@@ -141,7 +141,6 @@ get_deps() {
get_serf
get_zlib
get_sqlite
- get_gtest
echo
echo "If you require mod_dav_svn, the recommended version of httpd is:"
[[[
Change default behaviour of get_deps.sh from downloading gtest
library to making it an optional target.
* get-deps.sh
(usage): Add gtest to list of possible arguments.
(get_deps): Remove gtest from list of default downloads.
Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
]]]
