On 24/01/13 15:53, Ben Reser wrote:
> On Wed, Jan 23, 2013 at 4:43 PM, Branko Čibej <br...@wandisco.com> wrote:
>> On 24.01.2013 00:42, Andreas Stieger wrote:
>>> Would something like this not be better?
>>>
>>> youngest common ancestor
>>> | last full merge
>>> | | tip of branch
>>> | | | repository path
>>>
>>> 2 6
>>> | |
>>> --| |------------ branches/branch1
>>> / /
>>> / /
>>> -------| |------------ trunk
>>> | |
>>> 5 6
> +0 on this.
>
>> The patch itself still makes translators deal with the position of the
>> vertical bars. If we're going to change the layout, we may as well make
>> it even easier for translators so that they don't have to worry about
>> positioning, just translating the headings.
> +1 on this.
Based on that feedback, the updates patch will produce to the same
output, but with the column headings translated as separate strings.
Andreas
Index: subversion/svn/mergeinfo-cmd.c
===================================================================
--- subversion/svn/mergeinfo-cmd.c (revision 1437751)
+++ subversion/svn/mergeinfo-cmd.c (working copy)
@@ -162,12 +162,14 @@ mergeinfo_diagram(const char *yca_url,
}
/* Column headings */
- SVN_ERR(svn_cmdline_fputs(
- _(" youngest last repos.\n"
- " common full tip of path of\n"
- " ancestor merge branch branch\n"
- "\n"),
- stdout, pool));
+ SVN_ERR(svn_cmdline_printf(pool,
+ " %s\n"
+ " | %s\n"
+ " | | %s\n"
+ " | | | %s\n"
+ "\n",
+ _("youngest common ancestor"), _("last full merge"),
+ _("tip of branch"), _("repository path")));
/* Print the diagram, row by row */
for (row = 0; row < ROWS; row++)
