Please attach patches as MIME text/plain (usually naming them *.txt does
that). More below.
> + if prefix and re.search(r'REPONAME', prefix):
Needlessly complicated, ('REPONAME' in prefix) would do.
Also I think you should use the %() syntax like mailer.conf.example
does. Is that possible?
> + reponame =
> os.path.basename(os.path.dirname(os.path.dirname(__file__)))
That's outright wrong. You can't assume that post-commit is a symlink
to mailer.py. (Just read post-commit.tmpl for a counterexample.)
> + prefix = re.sub(r'REPONAME', reponame, prefix)
Daniel
(very brief review, and the setup I help maintain uses svnmailer not
mailer.py, so if the above doesn't make sense sorry and please correct me)
