Philip Martin wrote: > Philip Martin <[email protected]> writes: >> What do people think? Good idea? Too ugly for the limited benefit?
+1. Good idea and not too ugly. I scanned through the patch and there are just two bits I find a bit ugly -- s/private/privat/ and s/template/templat/ -- and that's only my subjective language preference. Since the type of 'private' is id_private_t, I would suggest either 'id_private' or 'id' would make sense for a new name. Not sure about 'template'. >> None of the changes affect Subversion's public API. > > Oops! Looking at the log I see that this bit does change the API: > >> * subversion/include/svn_ra_svn.h >> (enum svn_ra_svn_item_kind_t): New, replaces enum nested in >> struct svn_ra_svn_item_t. > > I think that change is backward compatible for C. The enum identifiers > are already global in C. It is changing the type of svn_ra_svn_item_t > but only replacing one enum with another. That sounds correct to me. - Julian
