On 04/12/2013 12:27 PM, Daniel Shahaf wrote:
> Prompted by Julian's review of this freshly-minted public API on IRC:
> 
> 1. Question to API consumers (eg, client developers): would you find
> this API useful?  For reference, the current docstring is attached.

N/A

> 2. Should we print the symbolic name in release builds?

No!  Very low signal-to-noise ratio change, that.  (And in the cases where
it's *not*, then I submit it's our error strings themselves that need to be
fixed!)

> 3. Should the API return the error code, or the error code without the
> "SVN_ERR_" prefix?

It should return the full error code, allowing this function to -- perhaps
someday -- accurately identify APR_* or SERF_* error codes without needing
to add an additional return parameter to identify the namespace of the
symbolic name.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to