Branko Čibej <br...@wandisco.com> writes: > This discussion is out of date, I committed a different fix yesterday > that doesn't require premature initialization, yet avoids the > uninitialized-read problem.
There was no uninitialized read to avoid. My compiler now produces: ../src/subversion/libsvn_fs_fs/tree.c: In function 'open_path': ../src/subversion/libsvn_fs_fs/tree.c:956:13: warning: 'rest' may be used uninitialized in this function [-Wmaybe-uninitialized] which is essentially the same as the original warning that Blair saw: ../src/subversion/libsvn_fs_fs/tree.c: In function 'open_path': ../src/subversion/libsvn_fs_fs/tree.c:929:27: warning: 'directory' may be used uninitialized in this function [-Wmaybe-uninitialized] These warnings are "maybe" which means there will be false positives and different compilers will have different results. I see a number of false positives with gcc 4.7.2 and I don't think we should be adding spurious initialisation to make them go away. Why do people want to fix this particular instance? -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
