On 03.07.2013 13:37, Daniel Shahaf wrote: > [email protected] wrote on Wed, Jul 03, 2013 at 10:49:02 -0000: >> + notify_failure->warning_str = apr_psprintf(pool, >> + _("E%06d: %s"), > Would it make sense to push the E%06d: part down to the implementation > of svn_err_best_message()? > > I.e., if the information is useful for this caller, presumably it'll be > useful for others too?
Error message formatting should not be the domain of libsvn_subr. Different API consumers may want to format the error codes differently, and it's a bad idea to make them parse it out. -- Brane -- Branko Čibej | Director of Subversion WANdisco // Non-Stop Data e. [email protected]
