On Thu, Nov 14, 2013 at 6:13 PM, Branko Čibej <[email protected]> wrote:
> On 14.11.2013 17:50, Stefan Fuhrmann wrote: > > On Wed, Nov 13, 2013 at 1:19 PM, Julian Foad > <[email protected]>wrote: > >> > URL: http://svn.apache.org/r1540590 >> >> > Added: subversion/trunk/subversion/libsvn_subr/object_pool.c >> > >> ============================================================================== >> [...] >> > +svn_object_pool__create(..., >> > + apr_size_t min_unused, >> > + apr_size_t max_unused, ...) >> [...] >> > + /* paranoia limiter code */ >> > +#if APR_SIZET_MAX > APR_UINT32_MAX >> >> My compiler says: >> warning: "APR_SIZET_MAX" is not defined >> >> Presumably that means this block of code is never compiled. >> > > As it turns out, APR_SIZE_MAX can't be used either > nor anything based on sizeof(). So, I simply removed > the preprocessor code entirely in r1541924. Compilers > might complain about it being "always true" on 32 bit > machines. > > > What's wrong with > > # if sizeof(apr_size_t) > sizeof(apr_uint32_t) > > I'd expect that to work ... > Not in the C preprocessor apparently. -- Stefan^2.
