Hello, just noticed some warnings: subversion/tests/libsvn_fs_base/fs-base-test.c:239:6: warning: 'present' may be used uninitialized in this function [-Wmaybe-uninitialized] et al. Initializing to boolean value that would fail the test if the reference wasn't changed in called function at all.
[[[ * subversion/tests/libsvn_fs/fs-test.c (check_entry_present, check_entry_absent), subversion/tests/libsvn_fs_base/fs-base-test.c (check_entry_present, check_entry_absent, check_id_present, check_id_absent): initialize variable present to silence warning -Wmaybe-uninitialized ]]] Andreas
Index: subversion/tests/libsvn_fs/fs-test.c =================================================================== --- subversion/tests/libsvn_fs/fs-test.c (revision 1542431) +++ subversion/tests/libsvn_fs/fs-test.c (working copy) @@ -1020,7 +1020,7 @@ static svn_error_t * check_entry_present(svn_fs_root_t *root, const char *path, const char *name, apr_pool_t *pool) { - svn_boolean_t present; + svn_boolean_t present = false; SVN_ERR(check_entry(root, path, name, &present, pool)); if (! present) @@ -1037,7 +1037,7 @@ static svn_error_t * check_entry_absent(svn_fs_root_t *root, const char *path, const char *name, apr_pool_t *pool) { - svn_boolean_t present; + svn_boolean_t present = true; SVN_ERR(check_entry(root, path, name, &present, pool)); if (present) Index: subversion/tests/libsvn_fs_base/fs-base-test.c =================================================================== --- subversion/tests/libsvn_fs_base/fs-base-test.c (revision 1542431) +++ subversion/tests/libsvn_fs_base/fs-base-test.c (working copy) @@ -124,7 +124,7 @@ static svn_error_t * check_entry_present(svn_fs_root_t *root, const char *path, const char *name, apr_pool_t *pool) { - svn_boolean_t present; + svn_boolean_t present = false; SVN_ERR(check_entry(root, path, name, &present, pool)); if (! present) @@ -141,7 +141,7 @@ static svn_error_t * check_entry_absent(svn_fs_root_t *root, const char *path, const char *name, apr_pool_t *pool) { - svn_boolean_t present; + svn_boolean_t present = true; SVN_ERR(check_entry(root, path, name, &present, pool)); if (present) @@ -213,7 +213,7 @@ check_id(svn_fs_t *fs, const svn_fs_id_t *id, svn_ static svn_error_t * check_id_present(svn_fs_t *fs, const svn_fs_id_t *id, apr_pool_t *pool) { - svn_boolean_t present; + svn_boolean_t present = false; SVN_ERR(check_id(fs, id, &present, pool)); if (! present) @@ -233,7 +233,7 @@ check_id_present(svn_fs_t *fs, const svn_fs_id_t * static svn_error_t * check_id_absent(svn_fs_t *fs, const svn_fs_id_t *id, apr_pool_t *pool) { - svn_boolean_t present; + svn_boolean_t present = true; SVN_ERR(check_id(fs, id, &present, pool)); if (present)