Daniel Shahaf wrote: > URL: http://svn.apache.org/r1592724 > Log: > Follow-up to r3265 (r843339): In 'svn propget -r', error out on > non-existing properties.
Hi Daniel. Can I ask: Why? This makes 'propget --revprop' inconsistent with 'propget [versioned prop]' which still prints nothing. Did you intend to change both forms, for consistency with 'svnlook'? Previously, 'svn propget' would print nothing for a nonexistent prop (either versioned or revprop), while 'svnlook propget' would issue an error for a non-existent prop (either versioned or revprop), which was a bit more consistent than what we now have. - Julian > > * subversion/svn/propget-cmd.c > (svn_cl__propget): Handle the (propval == NULL) case. > > * subversion/include/svn_client.h > (svn_client_revprop_get): Document API behaviour on non-existing properties. > > * subversion/tests/cmdline/svnadmin_tests.py > (empty_date): Use exit code to verify lack of property. > > * subversion/tests/cmdline/prop_tests.py > (revprop_change): Same. 'propget' was actually already failing (with > the expected E200017), but the test was ignoring the exit code. > (I think the before-this-change code can never fail, since > re.match('cha-ching', 'cha-ching\n') would return False.)