On 4 February 2015 at 20:45, Julian Foad <julianf...@btopenworld.com> wrote: > So we're on the third version of the code and third version of the test, for a > tiny edge-case feature. Clearly it's fragile. I had a bad feeling about > writing it > this way in the first place. I had the same feelings when were reviewing backport nomination in 1.8.x.
I wonder why you duplicated code that parses svn:mergeinfo instead of using svn_mergeinfo_parse() ? I mean: 1. Parse svn:mergeinfo using svn_mergeinfo_parse() 2. For every path remove zero revision using svn_rangelist_remove() 3. Build new svn:mergeinfo using svn_mergeinfo_to_string() -- Ivan Zhakov