Julian Foad <[email protected]> writes: >> Should there be a command-line flag to disable casefolding? > > No. Not unless we also want to provide all the other kinds of control for > specialist searching, such as regexes, specifying which of the metadata > fields to look in, boolean operators, etc. -- and I think it would be silly > for the project to go that way. Like Brane said, keep it simple.
+1 Daniel Shahaf <[email protected]> writes: > P.S. This patch introduces a minor behaviour change: before this patch, > the search pattern «foo[A-z]bar» would match the log message «foo_bar», > whereas after this change it would not. (This is because the pattern is > now casefolded between being passed to APR, and '_' is between 'A' > and 'z' but not between 'A' and 'Z', when compared as C chars.) I doubt > anyone will notice this behaviour change; I'm just mentioning it for > completeness. That's a good point. However, I am not sure that there is an easy way to solve this (IMHO, edge) case. Regards, Evgeny Kotkov
