On Fri, Sep 16, 2016 at 03:42:58AM +0000, Daniel Shahaf wrote: > Daniel Shahaf wrote on Fri, Sep 09, 2016 at 06:44:51 +0000: > > 3. Add to svn_commit_info_t an svn_error_t representation of the error > > chain that svn_commit_callback_t::post_commit_err summarizes, > > Patch attached. > > The new test fails over ra_svn; I haven't investigated that yet. > > Does the approach look sane? This has more moving parts than a normal > add-member-to-struct patch because the new member is an svn_error_t so > it needs explicit clearing. > > Thanks, > > Daniel >
In your original post you stated: "The problem here is that the "post-commit hook failed" error isn't printed." If all you want to do is print a message, why not just pass a string around? Passing around (and having to marshal) a whole error chain seems like a rather complicated perfectionist approach for the problem at hand, don't you think? End-users won't care about the chain, they just care about the message. And developers might as well use a debugger to examine a post-commit error chain if needed.
