I moved your nominations to approved with another +0.
With our Subversion binding rules one +1 of a committer for that region (yours)
and one +0 from another is enough to approve changes for the binding code.
I’m not sure about the perl rules applied around this function, but perhaps we
should just copy the string instead of changing memory that we receive as
constant. We might also have a different api function that behaves in a cleaner
way.
(The current code is better than it used to be, so my +0 stands anyway)
Bert
From: Roderich Schupp [mailto:[email protected]]
Sent: woensdag 2 november 2016 21:07
To: Daniel Shahaf <[email protected]>
Cc: [email protected]; Subversion devel mailing list
<[email protected]>
Subject: Re: [PATCH] Perl bindings corrupt "{DATE}" revision variable
On Wed, Nov 2, 2016 at 8:41 PM, Daniel Shahaf <[email protected]
<mailto:[email protected]> > wrote:
Thanks, Roderich. Could you update the log message with an appropriate
"Verbed by"[1] clause, for contribulyzer?
Done.
I assume this should be backported, in which case, here is my +0 for
backport of the patch as committed.
Nominated for 1.8 and 1.9 incl. your vote.
Cheers, Roderich
