On 14.11.2016 12:21, Bert Huijben wrote:
-----Original Message-----
From: stef...@apache.org [mailto:stef...@apache.org]
Sent: zondag 13 november 2016 19:20
To: comm...@subversion.apache.org
Subject: svn commit: r1769532 - in /subversion/trunk/subversion:
include/private/svn_log.h libsvn_fs_x/fs.h libsvn_subr/log.c
Author: stefan2
Date: Sun Nov 13 18:19:37 2016
New Revision: 1769532
URL: http://svn.apache.org/viewvc?rev=1769532&view=rev
Log:
Fix a couple of integer conversion warnings.
Found by: brane
* subversion/libsvn_fs_x/fs.h
(svn_fs_x__changes_context): The NEXT element is used with APR arrays,
so it should be int.
* subversion/include/private/svn_log.h
(svn_log__list): DIRENT_FLAGS are always 64 bits, so this should be, too.
Why would this always be 64 bit?
I copied that from svn_log__get_dir.
svn_types.h has:
/** A combination of all the dirent fields */
#define SVN_DIRENT_ALL ~((apr_uint32_t ) 0)
And svn_client.h's svn_client_list4() (since svn_client_list()) uses
apr_uint32_t too.
With r1795617, all usages should be 32 bit.
-- Stefan^2.