Branko Čibej wrote on Sat, 17 Mar 2018 20:27 +0100: > On 17.03.2018 20:24, br...@apache.org wrote: > > > > + * r1825979 > > + Minor clarification to docstring. > > + Justification: > > + Trivial documentation fix. > > + Votes: > > + +1: danielsh, jamessan > > + -1: brane (the docstring "clarification" is wrong, since > > + we do not propagate the compression level to LZ4) > > > It seems I failed to this change on the list when it was originally made > on trunk. I believe r1825979 should be reverted because the change is > not correct.
Thanks for the review. Before r1825979 the docstring implied that wire compression always used zlib; r1825979 corrects that misimplication. I grant that it's not clear from the docstring that compression levels aren't honoured by all compression functions in use. It would be good to document that, possibly by reference (to svn_delta.h, I guess?). I'm afraid I don't have a specific suggestion at the moment; does anyone else? Cheers, Daniel
