On Tue, Dec 18, 2018 at 03:55:42AM +0100, Stefan Fuhrmann wrote: > Error handling during tear-down is always a bit messy. > > I guess not using the request struct will mean we cannot > tell what operation cased a problem - ever (not sure, > though). If true, that's a high cost. > > One way to improve your solution would be to make > the error handling degrade as the objects are being > destroyed. But it adds / duplicates a bit of code: > > * keep the logging based on request context > * apr_pool_pre_cleanup_register on the request pool, > a switch to the new connection-based logging >
That's a fair suggestion. I'll try to implement this. This problem is blocking me from using httpd 2.4 in my builds (yes, I should have upgraded this dependency a long time ago, I know...). So if your suggestion turns out to be too complicated then I will just go for my initial diff first and revisit this later. > Greetings from CN! Hah, sounds like you're having a great time :)
