On Mon, Sep 23, 2019 at 1:53 AM Yasuhito FUTATSUKI <futat...@poem.co.jp> wrote: > > On 2019/09/23 6:16, Johan Corveleyn wrote: > > On Sat, Sep 21, 2019 at 10:28 AM Yasuhito FUTATSUKI <futat...@poem.co.jp> > > wrote: > >> > >> On 2019/09/20 0:44, Daniel Shahaf wrote: > >>> Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: > >> > >>>> The FAIL on test_merge_peg3 is a newline style issue on reading file > >>>> in raw mode, which is introduced by my patch. > >>>> (https://svn.apache.org/viewvc/subversion/branches/swig-py3/subversion/bindings/swig/python/tests/client.py?view=annotate#l438) > >>>> > >>>> Rest of those errors and failures are in the tests that were added only > >>>> to swig-py, and it seems most of the causes of them are confusion of > >>>> paths in platform specific format and Subversion's canoical format, > >>>> as the comment in SubversionClientTestCase.test_update4() says. > >>>> > >>>> (I'll try to fix those issues on check-swig-py later, hopefully > >>>> next weekend.) > >>> > >>> Thanks! No rush. > >> > >> Now I re-sync swig-py3 branch with trunk and make a patch addressing > >> issues on testing on other than Unix/Linux platform. > >> > >> I've tested on FreeBSD 11.2, with Python 2.7 and Python 3.6. > >> > >> Could anyone please test it on Windows ? > > > > Tested on Windows 7, and yes, this fixes the previous test failures > > with Python 2.7.16. Thanks! > > > > Test output: > > [[[ > > Testing Release configuration on local repository. > > -- Running Swig Python tests -- > > ..............s......................................................................................................... > > ................................. > > ---------------------------------------------------------------------- > > Ran 153 tests in 63.214s > > > > OK (skipped=1) > > ]]] > > > > I've commited it, as r1866362. Thanks! > > > > > Building with Python 3.7.4 still fails with the same error though (no > > problem, I know your patch wasn't addressing that, just mentioning it > > here for completeness). Consequently I haven't been able to run the > > swig-python tests with python 3.7 yet. > > > > [[[ > > c:\python37\include\pytime.h(123): error C4115: 'timeval': named type > > definition in parentheses > > [C:\research\svn\dev\swig-py3\build\win32\vcnet-vcproj\libsvn_swig_py.vcxproj > > ]]] > > Here is a patch not to treat C4115 as error, globally. If this makes > it possible to build with Python 3.7 on Windows, then next step can be > to limit to apply this relaxation of compile option to files which > contains "#include <Python.h>" (most of them are generated by swig...).
Yes, that makes the build succeed, thanks. I can't comment on whether or not it's good to change this error into a warning overall, or just for a limited set of files. I'll leave that discussion to others :-). So, on to the next problem. When testing with Python 3.7.4 on Windows, I get the following error: [[[ C:\research\svn\dev\swig-py3>python win-tests.py -c --log-level=DEBUG --release --swig=python R:\test_py 'ruby' is not recognized as an internal or external command, operable program or batch file. Testing Release configuration on local repository. -- Running Swig Python tests -- Traceback (most recent call last): File "C:\research\svn\dev\swig-py3\subversion\bindings\swig\python\tests\run_all.py", line 23, in <module> import mergeinfo, core, client, delta, checksum, pool, fs, ra, wc, repository, \ File "C:\research\svn\dev\swig-py3\subversion\bindings\swig\python\tests\trac\versioncontrol\tests\__init__.py", line 23, in <module> from trac.versioncontrol.tests import svn_fs File "C:\research\svn\dev\swig-py3\subversion\bindings\swig\python\tests\trac\versioncontrol\tests\svn_fs.py", line 73, in <module> REPOS_URL = pathname2url(temp_path).encode('UTF-8') File "C:\Python37\lib\nturl2path.py", line 53, in pathname2url if not ':' in p: TypeError: a bytes-like object is required, not 'str' [Test runner reported failure] ]]] (The warning about 'ruby' is not a big deal I suppose, but it's also something I saw when running gen-make.py with python 3.7 -- not when I'm running it with python 2.7) -- Johan