> This has caused a test failure on the windows buildbot: > > https://ci.apache.org/builders/svn-windows-local/builds/3392/steps/Test%20fsfs%2Blocal/logs/faillog > > Can you please check what we should do about that?
I missed SkipUnless test decorator. The build_repcache() test should be skipped if read_rep_cache() is not supported by Python-SQLite version. I have attached a patch that fixes this. Regards, Denis Kovalchuk
Follow-up to r1875921: Add missing test decorator. Skip build_repcache() test if read_rep_cache() is not supported by Python-SQLite version. * subversion/tests/cmdline/svnadmin_tests.py (build_repcache): Add missing SkipUnless decorator. Patch by: Denis Kovalchuk <denis.kovalc...@visualsvn.com> Index: subversion/tests/cmdline/svnadmin_tests.py =================================================================== --- subversion/tests/cmdline/svnadmin_tests.py (revision 1875922) +++ subversion/tests/cmdline/svnadmin_tests.py (working copy) @@ -4038,6 +4038,7 @@ PROPS-END @SkipUnless(svntest.main.is_fs_type_fsfs) @SkipUnless(svntest.main.fs_has_rep_sharing) +@SkipUnless(svntest.main.python_sqlite_can_read_without_rowid) def build_repcache(sbox): "svnadmin build-repcache"
