On Fri, Jan 22, 2021 at 11:58:40PM +0900, Yasuhito FUTATSUKI wrote: > On 2021/01/22 21:05, Stefan Sperling wrote: > > On Fri, Jan 22, 2021 at 12:48:24PM +0100, Stefan Sperling wrote: > >> On Mon, Jan 18, 2021 at 04:30:27PM -0000, futat...@apache.org wrote: > >>> Author: futatuki > >>> Date: Mon Jan 18 16:30:27 2021 > >>> New Revision: 1885656 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1885656&view=rev > >>> Log: > >>> mailer.py: Restore Python 2 support. > >> > >> mailer.py's test suite starts failing with Python3 after this change. > >> I don't know yet how this could be fixed. I will try to find out. > > > > It seems this was fairly easy to fix. See http://svn.apache.org/r1885784 > > Thank you very much, and I'm sorry bother you. Actuall I didn't mailer.py's > test suite in source tree but used another scripts for check that I wrote > and isn't completed as tests yet, and my script didn't hit the error > pattern (perhaps my test case is always base_path is None). I'm still working > to add my script as additional tests, because current tests also don't > covered SMTPOutput and PipeOutput for Output, and propchange, propchange2, > lock and unlock commands, although my check script don't propchange > commnand yet.
Nice, that is great news! Improvements to the script's test suite will be very useful indeed. Thank you, Stefan
