Den ons 17 feb. 2021 19:47Daniel Shahaf <d...@daniel.shahaf.name> skrev:

> Daniel Sahlberg wrote on Wed, Feb 17, 2021 at 09:30:36 +0100:
> > Den tis 16 feb. 2021 kl 21:31 skrev Daniel Shahaf <
> d...@daniel.shahaf.name>:
> > >
> > > The newline between the «]» and the «[» would get copied to the output
> > > if the condition is true.  Is that intentional?
> >
> > No, didn't pay attention to how ezt added newlines. Better like this?
> > No extra newlines except that the comments are on separate lines to
> > make them easy to remove.
>
> +1.  More below.
>

Just to be sure I get this right: Should I count this as ok to do an
"approved by" commit (Hacking, Partial commit access)?

> +++ templates/rc-news.ezt       (working copy)
> > @@ -7,9 +7,13 @@
> > -   announcement</a> for more information about this release, and the
> > +   announcement</a> for more information about this release, and
> > the[if-any announcement_url][else]
>
> Your email client added a hard link break, breaking the patch.
>

Stupid Gmail. Anyone have a suggestion for a reasonable email client on
Windows?

> +|... and this end comment--->[end]
> >     <a href="/docs/release-notes/[major-minor].html">release notes</a>
> and
> >     <a href="
> https://svn.apache.org/repos/asf/subversion/tags/[version]/CHANGES";>
> >     change log</a> for information about what will eventually be
>
> Preëexisting issue: The whitespace (newline and spaces) between the «>»
> and the words "change log" should be removed, otherwise some browsers
> render an underlined space.
>

I'll fix this as well, this would qualify as an obvious fix, right?

Kind regards
Daniel Sahlberg

Reply via email to