Re. pristines-on-demand. I have re-based pristines-on-demand on top of
multi-wc-format, resulting in a new branch 'pristines-on-demand-on-mwf'.
On 'pristines-on-demand-on-mwf':
> * Make pristines-on-demand behaviour conditional on WC format.
Mostly done in r1897977.
I could do with some help on a SQL test FAIL, when testing against the
older WC format, in wc-queries-test 3: test_query_expectations(). It
looks like this:
$ (SRC_DIR=$PWD; cd obj-dir/subversion/tests/libsvn_wc &&
./wc-queries-test --cleanup
--config-file=$SRC_DIR/subversion/tests/tests.conf
--srcdir=$SRC_DIR/subversion/tests/libsvn_wc --wc-format-version=1.14 3
| sed "s#$SRC_DIR/##")
subversion/tests/libsvn_wc/wc-queries-test.c:815: (apr_err=SVN_ERR_TEST_FAILED)
svn_tests: E200006: STMT_SELECT_UNREFERENCED_PRISTINES: Uses pristine
with only 0 index component: ((null))
SELECT checksum FROM pristine WHERE refcount = 0
subversion/tests/libsvn_wc/wc-queries-test.c:868:
(apr_err=SVN_ERR_COMPOSED_ERROR)
svn_tests: E200042: Additional errors:
subversion/tests/libsvn_wc/wc-queries-test.c:868:
(apr_err=SVN_ERR_SQLITE_CONSTRAINT)
svn_tests: E200035: |SCAN TABLE pristine
FAIL: wc-queries-test 3: test query expectations
The failure is within:
if (item->search
&& ((item->expression_vars < 2 && is_node_table(item->table))
|| (item->expression_vars < 1))
&& !is_result_table(item->table))
I have taken a look and cannot work out what it means. Maybe the
statement needs to be made to match the exception clause
"in_list(primary_key_statements, i)", but that's just a semi-educated guess.
Can anyone more familiar with SQL or that test help out here please?
- Julian
