Vincent Lefevre wrote on Fri, Mar 11, 2022 at 12:09:59 +0100: > On 2022-03-11 10:29:12 +0000, Julian Foad wrote: > > Julian Foad wrote: > > > +1. Can you send a patch? > > > > By the way, the reason I ask if you would be willing, rather than "just > > quickly doing it" myself, is even a small "obvious" fix like this tends > > to require more than it initially looks like: checking if it's already > > done in head of trunk, > > This is what I'm looking at. > > > finding other similar places, > > I typically do a recursive grep to find the potential updates to be > done. > > > deciding if any of them shouldn't be updated for whatever reason, > > running the test suite, adjusting test results to match... > > Yes, this requires some time to do it well (I've already done such > kinds of changes in another project), mainly for checking. I suppose > that eveything the end user can see needs to be updated, but also > for the readers of the source code, e.g. comments like > > # See http://subversion.apache.org for more information.
+1 > I have a question for 2 kinds of files. I think that the URLs should > be updated too in these files, but I need confirmation: > * The "CHANGES" file. Most instances can be changed, yes, but some instances of "http://"; are shorthand for "any http://* or https://*"; URL and should probably be left alone. And naturally, http://third-party.example.com/ stuff shouldn't be changed unless the new value is verified to work. > * The .po files. The advantage is that this would avoid the need of > the update by the translators. A potential drawback is that the > additional character might need to adjust the formatting, e.g. to > fit on 80 columns where applicable (there aren't many concerned > lines, so that I could report any such formatting issue). +1 and thank you. Instead of reporting them, it might be easier for you to just leave the entire msgid/msgstr pair untouched. We could then generate a list of the remaining issues by grepping again, and the translator would notice the out-of-date message when they next update the translation. Cheers, Daniel
