On Wed, Aug 17, 2022 at 9:55 AM Vincent Lefevre <vincent-...@vinc17.net> wrote:
> On 2022-08-14 10:56:07 -0400, Nathan Hartman wrote: > > I'm attaching an updated patch with the following changes: > > > > (1) Revert LICENSE > > (2) Revert the license headers > > Your patch adds a trailing newline to 2 files: > subversion/tests/cmdline/svneditor.bat > tools/buildbot/slaves/win32-vcpkg/svntest-build.cmd Ironic that when I removed that from the other four files, I added it to these two. Good catch! I've attached a new patch obtained with > > perl -pi -e \ > 's[http://(subversion\.apache\.org|svnbook\.red-bean\.com)] > [https://\1]; > s[http://(www.apache.org)(?!/licenses)] > [https://\1]' **/*(.) > > and the manual formatting improvements on > > subversion/libsvn_repos/repos.c > tools/dev/contribulyze.py > > This corresponds to your patch without the added trailing newlines. Looks good to me. Thanks for doing that. I'll commit it shortly. Is there anything in particular you'd like the log message to say (other than credit for writing this patch of course)? Cheers, Nathan