On Fri, Sep 9, 2022 at 6:31 AM Bert Huijben <[email protected]> wrote: > > Why the branch? > Looks like a quite obvious fix to me, so you could have just committed this > to trunk.
That does seem a little excessive, doesn't it? :-) I'll merge and nominate for backport when I get to a computer. I wanted to write a regression test too, but got stuck there -- was looking for the right place to add it and something that already exercises that version API to use as a starting point. The test suite (without a new regression test) didn't throw up any complaints. Btw, while looking at this, I found we also aren't copying the 'external' flag (or file_external, I don't have the name handy at the moment), so I'll fix that too. AFAICT we're copying/translating everything else that has a representation in the older struct. So, just the lock and external flags are missing. > +1 on backporting this fix, although I would recommend users of the old (pre > 1.7) api to upgrade to the newer status apis, as that makes an insane amount > of performance difference on most platforms. Cool. I'll add your vote when I nominate it... Cheers, Nathan
