On Fri, Dec 22, 2023 at 7:46 AM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > Den fre 22 dec. 2023 kl 02:49 skrev Johan Corveleyn <jcor...@gmail.com>: ... >> Then, regardless of the above error, when I start building with >> msbuild, I run into following error: >> [[[ >> C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0\sqlite3.c(34597,42): >> error C4013: 'sqlite3PagerWalSystemErrno' undefined; assuming extern >> returning >> int >> [C:\research\svn\dev\subversion-1.14.3\build\win32\vcnet-vcproj\libsvn_subr.vcxproj] >> ]]] > > > The declaration is guarded by: > #if defined(SQLITE_USE_SEH) && !defined(SQLITE_OMIT_WAL) > > While the actual use seems to be guarded by > #ifdef SQLITE_USE_SEH > > In our code we have > $ grep -r SQLITE_OMIT_WAL > subversion/libsvn_subr/sqlite3wrapper.c:# define SQLITE_OMIT_WAL 1 > > I assume we trigger some bug in SQLite but I don't have time to dig into the > SQLite source code. It's not the first time we've hit errors with OMIT_WAL
Googling around I saw that you already reported this issue to sqlite [1], and it has since been fixed in their repository [2]. Thanks for that! After manually applying that patch here the problem is gone, so I was able to continue with sqlite 3.44.2. I went on to fix a couple of linking issues locally (possibly I'm building some dependencies in other ways than the SVN buildscripts on Windows expect them -- or our buildscripts simply are not adapted to recent changes in apr, apr-util and openssl, not sure -- the path of least resistance was copying some *.dll and *.lib files to where our scripts look for them). Now everything has been built successfully, and I'm running tests ... I hope to finish up and commit my signature later tonight or tomorrow morning. I'll send a transcript of my build steps in a new thread later. [1] https://sqlite.org/forum/info/9819032aac [2] https://sqlite.org/src/info/7374c2342e66b352 -- Johan
