Thank you for reasoning your point.
After doing additional research, I found that the `rulers` is used
less, so I decided to not add it.
I updated the patch and log message. For sure I included details about
support in different editors to the code and log message.
[[[
Specify guidelines and max_line_length properties from the EditorConfig.
Set the `guidelines` and `max_line_length` properties to 79 symbols from the
EditorConfig file. These properties are not commonly supported by editors [1],
[2]. The value `79 symbols` is described in the community guidelines, so these
properties in the EditorConfig file would help us to follow the rule.
[1] The `max_line_length` property is supported by Emacs, Vim, Neovim, Atom,
JetBrains IDEs, Kakoune, and Prettier.
[2] The `guidelines` property is supported by Visual Studio with
EditorConfig Guidelines or Editor Guidelines extensions.
* .editorconfig:
(guidelines, max_line_length): Set these properties to 79 symbols.
]]]
On Tue, May 21, 2024 at 9:22 AM Daniel Sahlberg
<[email protected]> wrote:
>
> Den mån 20 maj 2024 kl 18:53 skrev Timofey Zhakov <[email protected]>:
>>
>> Hello,
>>
>> Thank you for rapid response,
>>
>> On Mon, May 20, 2024 at 6:16 PM Daniel Sahlberg
>> <[email protected]> wrote:
>> >
>> > Hi
>> >
>> > I can find very little information about the guidelines keyword.
>> >
>> > Is this a widely supported option in .editorconfig or is it something
>> > specific to a certain IDE or even a certain plugin? In case of the latter
>> > I think it should be mentioned in the commit message.
>> No, this keyword is not that much supported. I have a Visual Studio
>> extension which provides support for this rule.
>
>
> Thanks for the expanation!
>
>>
>>
>> >
>> > Is the max_line_length a better option?
>> There are also some three common keywords for this rule: guidelines,
>> max_line_length, and rulers. Can we add them all?
>
>
> Why not?
>
>>
>> Do you agree with this if I mention details in the log message?
>
>
> Sure! The reason I suggest to have it in the log message is if someone down
> the road looks at the file and things "but guidelines isn't an editorconfig
> option..?", then it helps to look at blame and see "ah, it was for Visual
> Studio extention XYZ".
>
>>
>> With best regards,
>> Timofei Zhakov
--
Timofei Zhakov
ÿþI n d e x : . e d i t o r c o n f i g
= = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
- - - . e d i t o r c o n f i g ( r e v i s i o n 1 9 1 7 8 5 3 )
+ + + . e d i t o r c o n f i g ( w o r k i n g c o p y )
@ @ - 8 , 6 + 8 , 1 4 @ @ i n d e n t _ s i z e = 2
i n s e r t _ f i n a l _ n e w l i n e = t r u e
t r i m _ t r a i l i n g _ w h i t e s p a c e = f a l s e
+ # F o r c e s h a r d l i n e w r a p p i n g a f t e r t h e
a m o u n t o f c h a r a c t e r s s p e c i f i e d .
+ m a x _ l i n e _ l e n g t h = 7 9
+
+ # A d d s g u i d e l i n e s t o t h e e d i t o r . T h i s
o p t i o n i s u n o f f i c i a l , b u t i t i s
+ # s u p p o r t e d b y V i s u a l S t u d i o w i t h
E d i t o r C o n f i g G u i d e l i n e s o r E d i t o r
+ # G u i d e l i n e s e x t e n s i o n s .
+ g u i d e l i n e s = 7 9 d a s h e d
+
[ * * / M a k e f i l e * ]
i n d e n t _ s t y l e = t a b
i n d e n t _ s i z e = 8
