On 28. 2. 25 15:23, Daniel Sahlberg wrote:
Den fre 28 feb. 2025 kl 15:16 skrev Stefan Sperling <s...@apache.org>:On Fri, Feb 28, 2025 at 02:14:34PM +0100, Branko Čibej wrote: > This is probably the minimal patch to disable this tweak. Thanks, your diff looks good to me. > There's a bunch of > code that needs to be replaced or removed, though. These bits of code are easy to spot and remove. Here is a diff for that:Thanks to both Branko and Stefan. Both patches look good to me at a quick glance. I was about to do something similar myself.
r1924100
I assume the optimisation we can get from the vector instructions are a lot bigger than the "hand optimised" C code so it should be good to go and anyone performance critical will compile with vector instructions.
I'd be surprised if that wasn't the case. Anyway, at least in one case that I looked at (diff_file.c), the "optimization" adds another iteration over the in-memory data, and changes the semantics of the enclosing function. I have a hard time understanding how that makes anything faster.
-- Brane
