On Tue, May 20, 2025 at 9:29 PM Branko Čibej <br...@apache.org> wrote:
> On 20. 5. 25 20:31, rin...@apache.org wrote: > > Author: rinrab > Date: Tue May 20 18:31:35 2025 > New Revision: 1925722 > > URL: http://svn.apache.org/viewvc?rev=1925722&view=rev > Log: > On the 'utf8-cmdline-prototype' branch: add a new function that retrieves > target list from args, instead of converting the encoding, assumes that > args have already been converted. > > > > Once again, why don't you use apr_app_initialize() that does all that and > more, instead of perpetuating the same problem? As long as this is used on > Windows from main() instead of wmain(), there's no way it will work > consistently. > First I wanna mention that this exact change is still needed even if we decide to use apr app to host the binary. At this point there is no difference between using apr app and svn's implementation of wmain and main wrappers. Also, I'd like to argue about using apr app in general. The subversion's command line wasn't using this library during the whole history (as far as I know), so I don't think it's correct to start using it now. What would we do if we need some functionality apr app doesn't implement? I mean that would be a quite huge change... In my opinion, apr app is not something fully ready to use in subversion. For example, it doesn't wrap main on unix platforms, while it still can be executed with non-utf8-ized arguments. In wmain() apr_conv_ucs2_to_utf8() just ignores the error, which is bad (on win32). And finally, the code we have right now is pretty good, and it seems possible to support non-ASCII arguments (which I'm working on). I hope this makes some sense. -- Timofei Zhakov
