On 9. 6. 25 14:17, rin...@apache.org wrote:
Author: rinrab
Date: Mon Jun 9 12:17:12 2025
New Revision: 1926277
URL:http://svn.apache.org/viewvc?rev=1926277&view=rev
Log:
Use svn_opt_args_to_target_array3() instead of svn_opt__args_to_target_array()
and drop it.
[...]
Modified: subversion/trunk/subversion/include/private/svn_opt_private.h
URL:http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_opt_private.h?rev=1926277&r1=1926276&r2=1926277&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_opt_private.h (original)
+++ subversion/trunk/subversion/include/private/svn_opt_private.h Mon Jun 9
12:17:12 2025
@@ -90,16 +90,13 @@ svn_opt__arg_canonicalize_path(const cha
apr_pool_t *pool);
/*
- * Pull remaining target arguments from OS into *TARGETS_P,
- * converting them to UTF-8, followed by targets from KNOWN_TARGETS
- * (which might come from, for example, the "--targets" command line
- * option), which are already in UTF-8.
+ * Processes arguments from from @a utf8_input_targets into @a targets_p.
*
* On each URL target, do some IRI-to-URI encoding and some
* auto-escaping. On each local path, canonicalize case and path
* separators.
*
- * Allocate *TARGETS_P and its elements in POOL.
+ * Allocate @a targets_p and its elements in @a pool.
*
* If a path has the same name as a Subversion working copy
* administrative directory, return SVN_ERR_RESERVED_FILENAME_SPECIFIED;
This is not a Doxygen comment, @a does nothing. The convention for
non-Doxygen docstrings is to write function arguments in UPPERCASE. So
the first change should say:
Processes arguments from from UTF8_INPUT_TARGETS into *TARGETS_P
and the second change is unnecessary.
-- Brane
