minfrin commented on code in PR #32:
URL: https://github.com/apache/subversion/pull/32#discussion_r2179782779
##########
subversion/libsvn_ra_serf/util.c:
##########
@@ -958,7 +982,14 @@ svn_ra_serf__context_run(svn_ra_serf__session_t *sess,
_("Error running context"));
}
- return svn_ra_serf__wrap_err(status, _("Error running context"));
+ if (sess->ssl_error)
+ {
+ return sess->ssl_error;
+ }
+ else
+ {
+ return svn_ra_serf__wrap_err(status, _("Error running context"));
+ }
Review Comment:
Change makes a lot of sense, but we touch a lot of files.
```
subversion/libsvn_ra_serf/xml.c: return svn_ra_serf__wrap_err(status,
NULL);
subversion/libsvn_ra_serf/xml.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/sb_bucket.c: return
svn_ra_serf__wrap_err(status, _("Failed to read the request"));
subversion/libsvn_ra_serf/util.c: return svn_ra_serf__wrap_err(why,
NULL);
subversion/libsvn_ra_serf/util.c: return svn_ra_serf__wrap_err(status,
_("Error running context"));
subversion/libsvn_ra_serf/util.c: return svn_ra_serf__wrap_err(status,
NULL);
subversion/libsvn_ra_serf/util.c:
svn_ra_serf__wrap_err(status, NULL),
subversion/libsvn_ra_serf/multistatus.c: return
svn_ra_serf__wrap_err(result, NULL);
subversion/libsvn_ra_serf/update.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/update.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/update.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/update.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/update.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/update.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/update.c: return svn_ra_serf__wrap_err(status,
NULL);
subversion/libsvn_ra_serf/ra_serf.h:svn_ra_serf__wrap_err(apr_status_t
status,
subversion/libsvn_ra_serf/ra_serf.h:#define svn_ra_serf__wrap_err \
subversion/libsvn_ra_serf/ra_serf.h: (svn_error__locate(__FILE__,__LINE__),
(svn_ra_serf__wrap_err))
subversion/libsvn_ra_serf/commit.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/util_error.c:#undef svn_ra_serf__wrap_err
subversion/libsvn_ra_serf/util_error.c:svn_ra_serf__wrap_err(apr_status_t
status,
subversion/libsvn_ra_serf/get_file.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/get_file.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/get_file.c: return
svn_ra_serf__wrap_err(status, NULL);
subversion/libsvn_ra_serf/serf.c: return svn_ra_serf__wrap_err(
subversion/libsvn_ra_serf/serf.c: return svn_ra_serf__wrap_err(status,
NULL);
subversion/libsvn_ra_serf/serf.c: return svn_ra_serf__wrap_err(status,
NULL);
```
Is it ok to commit this in one step, or should this be a separate change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
