gstein commented on code in PR #33:
URL: https://github.com/apache/subversion/pull/33#discussion_r2193004781
##########
tools/hook-scripts/mailer/mailer.py:
##########
@@ -1401,7 +1401,9 @@ def repos_params(section_name, defaults):
# Extract key/value pairs from the regex match of this
# repository, and merge them into the default params.
# Make sure to copy() to avoid mutation of the argument.
- return defaults.copy().update(match.groupdict())
+ merged_defaults = defaults.copy()
+ merged_defaults.update(match.groupdict())
+ return merged_defaults
Review Comment:
Please, no Perl code. 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@subversion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
