On Sun, 13 Jul 2025 at 11:42 PM, Daniel Sahlberg < daniel.l.sahlb...@gmail.com> wrote:
> Den sön 13 juli 2025 kl 22:38 skrev <dsahlb...@apache.org>: > >> Author: dsahlberg >> Date: Sun Jul 13 20:38:53 2025 >> New Revision: 1927203 >> >> URL: http://svn.apache.org/viewvc?rev=1927203&view=rev >> Log: >> If we prepare an environment for Linux, better also check that the os is >> actually Linux. >> >> * .github/workflows/cmake.yml >> (#Prepare Environment (Linux)): Check for the correct OS. >> >> Modified: >> subversion/trunk/.github/workflows/cmake.yml >> >> Modified: subversion/trunk/.github/workflows/cmake.yml >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/.github/workflows/cmake.yml?rev=1927203&r1=1927202&r2=1927203&view=diff >> >> ============================================================================== >> --- subversion/trunk/.github/workflows/cmake.yml (original) >> +++ subversion/trunk/.github/workflows/cmake.yml Sun Jul 13 20:38:53 2025 >> @@ -107,7 +107,7 @@ jobs: >> ls env: | foreach { "$($_.Name)=$($_.Value)" >> >> $env:GITHUB_ENV } >> >> - name: Prepare Environment (Linux) >> - if: runner.os == 'Windows' >> + if: runner.os == 'Linux' >> run: | >> # nothing yet >> >> >> >> > We could probably even remove that step since it, as the code says, does > "# nothing yet". I presume it is there to have similar steps in both the > Windows and Linux builds, but since there is now also a macOS build which > doesn't have that step maybe it doesn't make sense anymore). > +1 to completely remove this step. > Cheers, > Daniel > >
