Den ons 24 dec. 2025 kl 18:59 skrev Evgeny Kotkov via dev < [email protected]>:
> Branko Čibej <[email protected]> writes: > > > Just a tiny nit: according to our ancient unwritten traditions, this > > macro should be called SVN_RA_SERF__EXPERIMENTAL. > > I agree the current name might feel a bit odd, although I think it should > be > consistent with existing names: > > - SVN_SERF_NO_LOGGING (this one is "public" and documented in /notes/knobs) > - SVN__SERF_TEST_HTTP2 > - SVN__SERF_EXPERIMENTAL > > > It refers to experimental usage of Serf in libsvn_ra_serf, the only place > > where Subversion uses Serf, so ... > > Naming it SVN_RA_SERF__EXPERIMENTAL would probably expand the scope a bit, > since it no longer reads like "experimental usage of Serf in > libsvn_ra_serf", > but more like "all experimental things in libsvn_ra_serf". > > To have the former meaning, we'd need an SVN_RA_SERF__SERF_EXPERIMENTAL. > Which would even be okay if we had e.g. SVN_RA_HTTP__SERF_EXPERIMENTAL, > but the SERF__SERF moment makes me think we might want to just keep the > current naming :) > > > Thanks, > Evgeny Kotkov > With the explanation by Evgeny, I think the current naming makes sense. I hope this can be a short-lived define... Should we document it in Knobs? Even if it is expexted to be short lived? Cheers, Daniel
