On Thu, Apr 30, 2026 at 2:04 AM Branko Čibej <[email protected]> wrote:

> On 29. 4. 26 21:37, [email protected] wrote:
>
> Author: rinrab
> Date: Wed Apr 29 19:37:32 2026
> New Revision: 1933532
>
> Log:
> Format code.
>
> * subversion/svnbrowse/svnbrowse.c
>   (get_item_style): Properly indent a nested switch.
>
> Modified:
>    subversion/trunk/subversion/svnbrowse/svnbrowse.c
>
> Modified: subversion/trunk/subversion/svnbrowse/svnbrowse.c
> ==============================================================================
> --- subversion/trunk/subversion/svnbrowse/svnbrowse.c Wed Apr 29 19:36:17 
> 2026        (r1933531)
> +++ subversion/trunk/subversion/svnbrowse/svnbrowse.c Wed Apr 29 19:37:32 
> 2026        (r1933532)
> @@ -403,14 +403,14 @@ get_item_style(const svn_browse__style_t
>                 svn_boolean_t selected)
>  {
>    switch (kind)
> -  {
> -    case svn_node_dir:
> -      return (selected) ? style->dir_selected : style->dir;
> -    case svn_node_file:
> -      return (selected) ? style->file_selected : style->file;
> -    default:
> -      abort();
> -  }
> +    {
> +      case svn_node_dir:
> +        return (selected) ? style->dir_selected : style->dir;
>
>
> Just curious, why are there parentheses around 'selected'? They're not
> needed.
>
> +      case svn_node_file:
> +        return (selected) ? style->file_selected : style->file;
> +      default:
> +        abort();
> +    }
>  }
>
>  static void
>
>
>
For fun.

I know they are not needed but IMO it makes it more readable.

-- 
Timofei Zhakov

Reply via email to