orbisai0security commented on PR #36: URL: https://github.com/apache/subversion/pull/36#issuecomment-4524721722
Thanks, both points make sense. I agree the patch should be split. The `assert` → explicit exception changes are independent from the file-mode change, and I’m happy to keep those as a separate cleanup if you think they’re worth committing. On the file-permission hardening: fair point about `~/.subversion/auth` already being created as `0700` by `ensure_authdirs()`. Given that, I agree this should not be presented as a security bug in the normal/default threat model. At most, creating the temp file as `0600` would be defence-in-depth for unusual/manual configurations where the directory permissions have been loosened, but that does not seem like something Subversion needs to treat as a vulnerability. I’ll rework this accordingly: separate the `assert` → `raise` cleanup from the file-mode change, and I’m fine dropping the file-mode part if maintainers don’t think it is useful. Is that okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
