Thanks William, I will do that in the future.
On Sun, Mar 10, 2013 at 4:52 PM, William Giokas <[email protected]> wrote: > On Sun, Mar 10, 2013 at 04:28:37PM -0400, Bobby Powers wrote: > > ha, sounds reasonable :) thanks Christoph! > > > > > > On Sun, Mar 10, 2013 at 4:17 PM, Christoph Lohmann <[email protected]> wrote: > > > > > Greetings. > > > > > > On Sun, 10 Mar 2013 21:17:38 +0100 Bobby Powers <[email protected] > > > > > wrote: > > > > Has an issue with st where the _'s were being overwritten when text > on > > > > the next line was drawn. This didn't happen in gnome-terminal, which > > > > uses pango for its font rendering. Pango's Xft backend uses ascent + > > > > descent rather than height. This appears to date back to at least > > > > 2004 (pango commit 5bf0c1d0) so I'm not sure their exact reasoning, > > > > but it fixes the Monospace font height issue I am seeing. > > > > > > I applied the patch without the big useless comment. If there would be > a > > > comment about all wrong behaviour of xft and how bad the fontconfig > API > > > is, st would double its raw source size. > > > > > When you send a git patch, you can put a message under the `---` but > above the diffstat and it'll not be included when you run `git am`. I > usually throw descriptions and reasoning in there. > > Thanks, > -- > William Giokas | KaiSforza > GnuPG Key: 0x73CD09CF > Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF >
