Quoth Evan Gates: > sbase-use_pe.diff : use parameter expansion instead of basename when > building sbase-box. simpler, shorter, no extra processes
I don't like this. The sbase Makefile is a really standard, basic, make at the moment (almost completely within the OpenGroup makefile spec), and AFAIK builds basically everywhere as a result. Parameter expansion is something I think of as a bashism, and I doubt is available everywhere. To my eyes it's uglier too. Spawning an extra process to call basename is less important than readability, though of course to an extent that's in the eye of the beholder. > sbase-align_redir.diff : cleanup the redirections for readability, > move them outside of loops I expected to dislike this, but actually it does make it more readable, even though I don't like alignment like this in the general case. Nick
