+1 (binding) Ville
> On 1. Dec 2020, at 20.31, Tai Dupree <[email protected]> wrote: > > *+1* (binding) > > On Wed, Nov 25, 2020 at 3:08 PM Rob DiCiuccio <[email protected]> wrote: > >> I appreciate the additional insights provided in the Github issue, thanks >> to all for the discussion. >> >> +1 (binding) on moving forward with RTL on an evaluation basis >> >> On Wed, Nov 25, 2020 at 10:47 AM Rob DiCiuccio <[email protected]> wrote: >> >>> I'd like to better understand what problems with the Enzyme testing flow >>> we're trying to solve with this migration. The SIP states only that >> Enzyme >>> is "running behind in catching up with all the latest React trends" and >>> "doesn’t support the useEffect hook" as rationale. I would argue that we >>> should not be chasing the latest trends without a good reason to do so, >> and >>> while hooks are currently popular, we have not agreed on hooks as our >>> accepted approach going forward. >>> >>> Let's continue the discussion in the Github issue. >>> >>> On Mon, Nov 23, 2020 at 9:54 PM Jesse Yang <[email protected]> wrote: >>> >>>> Hi All, >>>> >>>> I'm calling a vote for >>>> https://github.com/apache/incubator-superset/issues/11688 < >>>> https://github.com/apache/incubator-superset/issues/11688> >>>> >>>> Here's an accompanying PR: >>>> https://github.com/apache/incubator-superset/pull/11771 < >>>> https://github.com/apache/incubator-superset/pull/11771> >>>> >>>> >>>> Thanks, >>>> Jesse >>>> >>>> >>>> >>> >>> -- >>> >>> *Rob DiCiuccio* (he/him) >>> Director of Engineering >>> Preset | https://preset.io >>> >> >> >> -- >> >> *Rob DiCiuccio* (he/him) >> Director of Engineering >> Preset | https://preset.io >>
smime.p7s
Description: S/MIME cryptographic signature
