Hi all,

as this issue was already present in 1.0.0, I see little reason to postpone the 
release of 1.0.1 due to this bug, as there are countless other fixes present in 
this release candidate. I’m not sure if you were aware, but this rc actually 
includes a fix to a bug in word cloud which caused the top words to not always 
be displayed on the chart despite being present in the result set: 
https://github.com/apache-superset/superset-ui/pull/841

Having said that, we should definitely fix this, and we’ll make it top priority 
for 1.0.2 to have all charts that have been affected by this change to either 
revert to their original behavior and/or introduce a control to opt in/out of 
sorting. Please see ongoing work in this area: 
https://github.com/apache-superset/superset-ui/pull/939

Ville

> On 5. Feb 2021, at 0.44, Junlin Chen <jun...@preset.io> wrote:
> 
> Hi Byran,
> Thanks for bringing up this issue. We are aware of it and are planning to
> do a thorough audit to go over all chart control panels and build query
> code to ensure we get the "order by" control to all charts, which will take
> a week or so to finish.
> I don't think the community should wait longer for v1.0.1 patch, given 1)
> quite a few fixes for v1.0 need to get out soon 2)master is not in its best
> shape .....
> 
> We have prioritized the ORDER BY issue, and will do a fast follow with
> v1.0.2. We apologize for the inconvenience! 🙏
> 
> +1 on rc2
> 
> -junlin
> 
> On Thu, Feb 4, 2021 at 8:21 AM Bryan Keller <brya...@gmail.com> wrote:
> 
>> -1
>> 
>> The word cloud chart and line chart with group by have a similar lack of
>> "order by" issue that the bar chart had. I feel this regression from
>> earlier versions is serious enough that a fix should be included.
>> 
>> (For reference, see https://github.com/apache/superset/pull/12674 <
>> https://github.com/apache/superset/pull/12674>)
>> 
>> 
>>> On Feb 2, 2021, at 11:12 AM, Ville Brofeldt <ville.v.brofe...@gmail.com>
>> wrote:
>>> 
>>> Hello Superset Community,
>>> 
>>> This is a call for the vote to release Apache Superset version 1.0.1. The
>>> second release candidate includes the following cherries on top of the
>> ones
>>> featured in rc1:
>>> - feat(release): add github token to changelog script (#12872)
>> (@dpgaspar)
>>> - fix: allow users to reset their passwords (#12886) (@dpgaspar)
>>> - fix(menu): always show settings dropdown (#12877) (@nytai)
>>> - fix(release): add typing-extensions as dependency (#12648) (@villebro)
>>> - fix: Presto column_type_mappings time and timestamp (#12861)
>> (@rmgpinto)
>>> - fix: bar chart data order (#12665) (@kstrz)
>>> - add order by for bar charts (#12661) (@bryanck)
>>> 
>>> Big thanks to everyone who participated in testing the release candidate,
>>> reporting issues and fixing bugs!
>>> 
>>> The release candidate:
>>> https://dist.apache.org/repos/dist/dev/superset/1.0.1rc2/
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/superset/tree/1.0.1rc2
>>> 
>>> The Change Log for the release:
>>> https://github.com/apache/superset/blob/1.0.1rc2/CHANGELOG.md
>>> 
>>> The Updating instructions for the release (no changes since 1.0.0):
>>> https://github.com/apache/superset/blob/1.0.1rc2/UPDATING.md
>>> 
>>> public keys are available at:
>>> 
>>> https://www.apache.org/dist/superset/KEYS
>>> 
>>> The vote will be open for at least 72 hours or until the necessary number
>>> of votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks,
>>> The Apache Superset Team
>> 
>> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to