Thanks Ville, that makes sense, and I agree that the goal is to move toward stability, and understand the uncertainty when cherrying with merge-conflicts. I feel more comfortable knowing that these are updates to dependencies to fix merge conflicts, and agree about continuing the conversation about how to handle merge conflicts in the future. I haven’t tested this release so I’ll hold off on voting, but my concerns have been addressed.
Thanks again, Elizabeth > On Sep 8, 2021, at 2:28 AM, Ville Brofeldt <ville.v.brofe...@gmail.com> wrote: > > Hi, > > good catch Elizabeth, and I agree, we should not include new features in > patch releases. I should have explained the reason for these - the features > were needed to avoid having to resolve charring conflicts. Let me break up > the PRs that were flagged as features and the motivations for including them: > > #16594 feat: Experimental cross-filter plugins (@simcha90) > > - this was in fact mislabeled, and should have been a fix (adds the > experimental tag to native filters that can be used as viz plugins when the > appropriate feature flag is enabled) > > #16416 feat: add Shillelagh DB engine spec (@betodealmeida) > > - needed to unblock #16515 and #16526 (pinned Snowflake connector version) > > #16167 feat: Adding Rockset db engine spec (@srinify) > > - also needed fo unblock #16515 and #16526 > > Both #16416 and #16167 would have been easy to resolve manually, but whenever > possible, I try to avoid manually resolving cherry conflicts, as doing so > introduces risk of its own. But happy to open up the discussion about how to > handle cherry conflicts in future releases. > > Ville > > >> On 8. Sep 2021, at 8.48, Elizabeth Thompson <eschu...@gmail.com> wrote: >> >> I’m so glad to see a patch release follow up to 1.3.0. I feel though that if >> we truly wanted to call this a patch/fix release that it should only have >> bug fixes and no features. I would propose to only include the fixes and >> leave the feature cherries for 1.4.0. >> >> Elizabeth >> >>> On Sep 7, 2021, at 10:26 AM, Ville Brofeldt <ville.v.brofe...@gmail.com> >>> wrote: >>> >>> Hi all, >>> >>> Sure thing, happy to kick off an rc2 with #16258. However, AFAIK it only >>> affects Presto, so rc1 should still be fine on other connections. So I’ll >>> leave the rc open for a while longer, and will bake rc2 later this week if >>> other important bugs/fixes surface. >>> >>> Ville >>> >>>> On 7. Sep 2021, at 17.54, Erik Ritter <erik.t.rit...@gmail.com> wrote: >>>> >>>> -1, as this is missing a pretty big cherry just fixed by Ville himself! >>>> >>>> I'd recommend recutting a branch with >>>> https://github.com/apache/superset/pull/16614 added that resolves >>>> https://github.com/apache/superset/issues/16258. >>>> >>>> Best, >>>> Erik >>>> >>>>> On Tue, Sep 7, 2021 at 4:11 AM Yongjie <yongjiez...@apache.org> wrote: >>>>> >>>>> +1 (binding) >>>>> >>>>> On Mon, Sep 6, 2021 at 9:11 PM Ville Brofeldt <ville.v.brofe...@gmail.com> >>>>> wrote: >>>>> >>>>>> FYI, the image is now also available on docker hub: >>>>>> >>>>>> >>>>>> >>>>> https://hub.docker.com/layers/apache/superset/1.3.1rc1-dev/images/sha256-8f459c1568650201d99fc76d84bdfcc2a5358e0ac25e96143bf01c9d1481df49?context=explore >>>>>> >>>>>> Ville >>>>>> >>>>>> On 6. Sep 2021, at 15.33, Ville Brofeldt <ville.v.brofe...@gmail.com> >>>>>> wrote: >>>>>> >>>>>> Hello Superset Community, >>>>>> >>>>>> This is a call for the vote to release Apache Superset version 1.3.1. >>>>>> This release candidate includes the following cherries on top of 1.3.0: >>>>>> >>>>>> Features: >>>>>> - #16594 feat: Experimental cross-filter plugins (@simcha90) >>>>>> - #16416 feat: add Shillelagh DB engine spec (@betodealmeida) >>>>>> - #16167 feat: Adding Rockset db engine spec (@srinify) >>>>>> >>>>>> Fixes: >>>>>> - #16592 fix: Remove export CSV in old filter box (@duynguyenhoang) >>>>>> - #16573 fix: impersonate user label/tooltip (@betodealmeida) >>>>>> - #16412 fix: Support Jinja template functions in global async queries >>>>>> (@robdiciuccio) >>>>>> - #16482 fix: can't drop column when name overlap (@zhaoyongjie) >>>>>> - #16526 fix: Set correct comparison operator for snowflake-sqlalchemy >>>>>> pinning (@danielewood) >>>>>> - #16372 fix: ensure setting operator to `None` (#16371) (@grumpy-miner) >>>>>> - #16515 fix: Pin snowflake-sqlalchemy to 1.2.4 (@danielewood) >>>>>> - #16468 fix(native-filters): handle undefined control value gracefully >>>>>> (@villebro) >>>>>> - #16464 fix: prevent page crash when chart can't render (@zhaoyongjie) >>>>>> - #16460 fix(native-filters): handle null values in value filter >>>>>> (@villebro) >>>>>> - #16299 fix: copy to Clipboard order (@AAfghahi) >>>>>> - #16369 fix: call external metadata endpoint with correct rison object >>>>>> (@villebro) >>>>>> - #16293 fix(sqlite): week grain refer to day of week (@villebro) >>>>>> - #16193 refactor: external metadata fetch API (@zhaoyongjie) >>>>>> >>>>>> The release candidate: >>>>>> https://dist.apache.org/repos/dist/dev/superset/1.3.1rc1/ >>>>>> >>>>>> Git tag for the release: >>>>>> https://github.com/apache/superset/tree/1.3.1rc1 >>>>>> >>>>>> The Change Log for the release: >>>>>> https://github.com/apache/superset/blob/1.3.1rc1/CHANGELOG.md >>>>>> >>>>>> The Updating instructions for the release (unchanged from 1.3.0): >>>>>> https://github.com/apache/superset/blob/1.3.1rc1/UPDATING.md >>>>>> >>>>>> public keys are available at: >>>>>> >>>>>> https://www.apache.org/dist/superset/KEYS >>>>>> >>>>>> The vote will be open for at least 72 hours or until the necessary number >>>>>> of votes are reached. >>>>>> >>>>>> Please vote accordingly: >>>>>> >>>>>> [ ] +1 approve >>>>>> [ ] +0 no opinion >>>>>> [ ] -1 disapprove with the reason >>>>>> >>>>>> Thanks, >>>>>> The Apache Superset Team >>>>>> -------------------------- >>>>>> >>>>>> >>>>>> >>>>> >>> >
