Thanks for testing this user flow Ville. I'll -1 (binding) as well and agree with your proposal.
Erik On Wed, Nov 24, 2021 at 4:29 AM Ville Brofeldt <[email protected]> wrote: > Hi, > > -1 (binding) > > during testing I noticed that Filter Boxes weren’t working properly. When > I cherried this PR in they started working again: > https://github.com/apache/superset/pull/17311 While native filters are > now enabled by default, I believe we should still make sure filter boxes > are supported in this release, hence going to vote -1 and propose cherrying > in #17311 for rc2. > > Ville > > On 23. Nov 2021, at 5.20, Yongjie <[email protected]> wrote: > > +1 binding > > On Tue, Nov 23, 2021 at 11:16 AM Beto Dealmeida > <[email protected]> wrote: > > +1, binding. > > Checked: > > [x] Download links are valid > [x] GPG and checksum (SHA512) are valid > [x] Includes ASF license file (LICENSE.txt) and NOTICE file > [x] No unexpected binary code > > Tested: > > [x] Load examples > [x] All example dashboards load correctly > [x] Run query in SQL Lab > [x] Create virtual dataset (SQL Lab -> Explore) > [x] Add new database (GSheets) > [x] Add dataset to GSheets database > [x] Explore new dataset > [x] Query GSheets spreadsheet in SQL Lab > > Thanks for the release! > > --Beto > > > On Tue, Nov 23, 2021 at 02:24:33AM +0000, [email protected] wrote: > > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 1.4.0. > > The release candidate: > https://dist.apache.org/repos/dist/dev/superset/1.4.0rc1/ > > Git tag for the release: > https://github.com/apache/superset/tree/1.4.0rc1 > > The Change Log for the release: > https://github.com/apache/superset/blob/1.4.0rc1/CHANGELOG.md > > The Updating instructions for the release: > https://github.com/apache/superset/blob/1.4.0rc1/UPDATING.md > > public keys are available at: > > https://www.apache.org/dist/superset/KEYS > > The vote will be open for at least 72 hours or until the necessary number > of votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > The Apache Superset Team > > > > > -- > > Best regards, > > Yongjie > > >
