Thank you Elizabeth! I appreciate all the work you (and all our release managers do) to ensure a solid official release.
Erik On Thu, Dec 16, 2021 at 5:53 PM Elizabeth Thompson <[email protected]> wrote: > Thank you Erik for flagging that. I’ll leave the vote open for the full 72 > hours, but start to work on another RC, as it looks like this is going to > require another round. > > > On Dec 16, 2021, at 11:36 AM, Erik Ritter <[email protected]> > wrote: > > > > -1 > > > > https://github.com/apache/superset/pull/17570 is included in this RC, > but > > not the fixes https://github.com/apache/superset/pull/17766 and > > https://github.com/apache/superset/pull/17781. As #17570 both > significantly > > inflates the dashboard payload, and breaks MySQL handling of non-ascii > > characters, we probably need the follow up fixes in the release as well. > > > > Thanks, > > Erik > > > > On Thu, Dec 16, 2021 at 10:45 AM Beto Dealmeida > > <[email protected]> wrote: > > > >> +1, binding. > >> > >> Checked: > >> > >> [x] Download links are valid > >> [x] GPG and checksum (SHA512) are valid > >> [x] Includes ASF license file (LICENSE.txt) and NOTICE file > >> [x] No unexpected binary code > >> > >> Tested: > >> > >> [x] Load examples > >> [~] All example dashboards load correctly (see below in "Problems") > >> [x] Run query in SQL Lab > >> [x] Create virtual dataset (SQL Lab -> Explore) > >> [x] Add new database (GSheets) > >> [x] Add dataset to GSheets database > >> [x] Explore new dataset > >> [x] Query GSheets spreadsheet in SQL Lab > >> > >> Problems: > >> > >> - The "New Members per Month" chart in "Slack Dashboard" is saved with a > >> time range without data ("Last Year"). I fixed it on > >> https://github.com/apache/superset/pull/17783 and I don't think this > is a > >> blocker. > >> - The "deck.gl Demo" dashboard does not load, showing an error > >> (Unexpected error: TypeError: cannot use 'in' operator to search for > >> "config" in "label_colors"). > >> - Most Deck.gl visualizations work. The "Arcs" chart didn't load for me, > >> being stuck in the spinner. The "Path" chart loads, but I don't see the > >> Bart lines. > >> > >> Personally, given the fact that the Deck.gl visualizations are 2nd tier > I > >> don't think these bugs are blockers, which is why I'm voting +1. But we > >> definitely should fix these problems for the next release. > >> > >> --Beto > >> > >> > >> On 12/15/21 7:18 PM, [email protected] wrote: > >>> Hello Superset Community, > >>> > >>> This is a call for the vote to release Apache Superset version 1.4.0. > >>> > >>> The release candidate: > >>> https://dist.apache.org/repos/dist/dev/superset/1.4.0rc2/ > >>> > >>> Git tag for the release: > >>> https://github.com/apache/superset/tree/1.4.0rc2 > >>> > >>> The Change Log for the release: > >>> https://github.com/apache/superset/blob/1.4.0rc2/CHANGELOG.md > >>> > >>> The Updating instructions for the release: > >>> https://github.com/apache/superset/blob/1.4.0rc2/UPDATING.md > >>> > >>> public keys are available at: > >>> > >>> https://www.apache.org/dist/superset/KEYS > >>> > >>> The vote will be open for at least 72 hours or until the necessary > number > >>> of votes are reached. > >>> > >>> Please vote accordingly: > >>> > >>> [ ] +1 approve > >>> [ ] +0 no opinion > >>> [ ] -1 disapprove with the reason > >>> > >>> Thanks, > >>> The Apache Superset Team > >> > >> > >
